Davidian1024/fctc-website-under-construction
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Keep the Cloudflare token out of stack config

Browse Source 
pulumi config set --secret writes ciphertext into Pulumi.dev.yaml, which is
committed, alongside the encryptionsalt. This stack's secrets provider is a
passphrase, and the passphrase is the empty string documented three lines above
it in the README. That combination is not encryption — it is the token spelled
differently, readable by anyone with access to this repo.

pulumi-cloudflare falls back to CLOUDFLARE_API_TOKEN when cloudflare:apiToken
is absent from config, so __main__.py is unchanged and so is pulumi up. The
token simply stops living in git.

The empty passphrase is left as it is. It protects nothing precisely because
nothing secret is in config any more, and that is what makes it harmless; the
notes now say to change the secrets provider before adding a secret at rest.

This does NOT un-expose the existing token. The value is still readable in this
branch's history at 94dd775, and history rewriting would not help either, since
it has been pushed since 2026-09-09. Only rotating the credential closes that;
notes/CLOUDFLARE.md now covers how, including checking Last used before
deleting the token, which is the only record of whether it was ever used.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Raúl Montejo
2026-09-17 23:27:08 -04:00
parent 94dd775061
commit f00a96c40b
4 changed files with 64 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
infra/notes/CLOUDFLARE.md
View File

@@ -28,3 +28,34 @@ https://dash.cloudflare.com/profile/api-tokens
8. Click "Create Token"
9. The token will only be displayed once.
### Where the token goes
**Into the environment, never into `pulumi config`.**
```bash
export CLOUDFLARE_API_TOKEN=...
pulumi up
```
`pulumi-cloudflare` falls back to `CLOUDFLARE_API_TOKEN` when `cloudflare:apiToken` is
not set in config, so this needs no change to `__main__.py`.
Do **not** run `pulumi config set cloudflare:apiToken --secret`. On this stack that writes
ciphertext into the committed `Pulumi.dev.yaml`, next to a committed salt, unlocked by a
passphrase documented in `../README.md`. See `./PASSPHRASE.md`.
For anything unattended later, put it in a GitHub Actions secret and export it in the job
rather than committing it in any form.
### If a token has been exposed
Rotating the value is the only fix — rewriting git history does not help, because anyone
with repo access has already been able to read it for as long as it was pushed.
1. https://dash.cloudflare.com/profile/api-tokens, signed in as the user who created it
(tokens are user-scoped, so only that user sees them).
2. Check **Last used** before doing anything — deleting the token destroys the only
record of whether it was used.
3. **Roll** to keep the token and issue a new value, or **Delete** and create a fresh one
from the steps above.